lib/src/js_ast/printer.dart - Issue 2201973002: fix optional params to mock methods, allow all signatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/js_ast/printer.dart

Issue 2201973002: fix optional params to mock methods, allow all signatures (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: fix getters and setters Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/js_ast/printer.dart

diff --git a/lib/src/js_ast/printer.dart b/lib/src/js_ast/printer.dart

index 29bd7797c0335356a5e2fab89a39b3b627d5acb0..9e764aff0cce15da1274e40393f1676848cda647 100644

--- a/lib/src/js_ast/printer.dart

+++ b/lib/src/js_ast/printer.dart

@@ -945,7 +945,8 @@ class Printer extends TypeScriptTypePrinter implements NodeVisitor {

visitArrowFun(ArrowFun fun) {

localNamer.enterScope(fun);

if (fun.params.length == 1 &&

- (fun.params.single.type == null || !options.emitTypes)) {

+ fun.params[0] is Identifier &&

+ (!options.emitTypes || fun.params[0].type == null)) {

visitNestedExpression(fun.params.single, SPREAD,

newInForInit: false, newAtStatementBegin: false);

} else {