fix optional params to mock methods, allow all signatures

test/codegen_expected/language/cyclic_import_test.js

 dart_library.library('language/cyclic_import_test', null, /* Imports */[
   'dart_sdk',
   'expect'
 ], function load__cyclic_import_test(exports, dart_sdk, expect) {
   'use strict';
   const core = dart_sdk.core;
   const dart = dart_sdk.dart;
   const dartx = dart_sdk.dartx;
   const expect$ = expect.expect;
   const cyclic_import_test = Object.create(null);
@@ skipping 259 matching lines @@
   const cyclic_import_test$128 = Object.create(null);
   const sub__sub$128 = Object.create(null);
   const cyclic_import_test$129 = Object.create(null);
   const sub__sub$129 = Object.create(null);
   const cyclic_import_test$130 = Object.create(null);
   const sub__sub$130 = Object.create(null);
   const cyclic_import_test$131 = Object.create(null);
   const sub__sub$131 = Object.create(null);
   const cyclic_import_test$132 = Object.create(null);
   const sub__sub$132 = Object.create(null);
-  const cyclic_import_test$133 = Object.create(null);
-  const sub__sub$133 = Object.create(null);
-  const cyclic_import_test$134 = Object.create(null);
-  const sub__sub$134 = Object.create(null);
   let VoidTodynamic = () => (VoidTodynamic = dart.constFn(dart.definiteFunctionType(dart.dynamic, [])))();
-  cyclic_import_test$134.value = 42;
-  cyclic_import_test$134.main = function() {
-    sub__sub$134.subMain();
+  cyclic_import_test$132.value = 42;

[vsm, 2016/08/01 23:14:32]

Unrelated to your CL - but maybe something unstable here?

[Jennifer Messerly, 2016/08/01 23:18:01]

yup. Not sure what though...

+  cyclic_import_test$132.main = function() {
+    sub__sub$132.subMain();
   };
-  dart.fn(cyclic_import_test$134.main, VoidTodynamic());
-  sub__sub$134.subMain = function() {
-    expect$.Expect.equals(42, cyclic_import_test$134.value);
+  dart.fn(cyclic_import_test$132.main, VoidTodynamic());
+  sub__sub$132.subMain = function() {
+    expect$.Expect.equals(42, cyclic_import_test$132.value);
   };
-  dart.fn(sub__sub$134.subMain, VoidTodynamic());
+  dart.fn(sub__sub$132.subMain, VoidTodynamic());
   // Exports:
   exports.cyclic_import_test = cyclic_import_test;
   exports.sub__sub = sub__sub;
   exports.cyclic_import_test = cyclic_import_test$;
   exports.sub__sub = sub__sub$;
   exports.cyclic_import_test = cyclic_import_test$0;
   exports.sub__sub = sub__sub$0;
   exports.cyclic_import_test = cyclic_import_test$1;
   exports.sub__sub = sub__sub$1;
   exports.cyclic_import_test = cyclic_import_test$2;
@@ skipping 251 matching lines @@
   exports.cyclic_import_test = cyclic_import_test$128;
   exports.sub__sub = sub__sub$128;
   exports.cyclic_import_test = cyclic_import_test$129;
   exports.sub__sub = sub__sub$129;
   exports.cyclic_import_test = cyclic_import_test$130;
   exports.sub__sub = sub__sub$130;
   exports.cyclic_import_test = cyclic_import_test$131;
   exports.sub__sub = sub__sub$131;
   exports.cyclic_import_test = cyclic_import_test$132;
   exports.sub__sub = sub__sub$132;
-  exports.cyclic_import_test = cyclic_import_test$133;
-  exports.sub__sub = sub__sub$133;
-  exports.cyclic_import_test = cyclic_import_test$134;
-  exports.sub__sub = sub__sub$134;
 });