Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2201953003: Revert "Also attempt to symbolize dart frames in Profiler::DumpStackTrace." (Closed)

Created:
4 years, 4 months ago by rmacnak
Modified:
4 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Also attempt to symbolize dart frames in Profiler::DumpStackTrace." This reverts commit d215693513f883e3c59a97daacca01b1048d4820. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/cdae2f2783c5fc0661c8aa385105070c147b5482

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -31 lines) Patch
M runtime/vm/profiler.cc View 2 chunks +9 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 4 months ago (2016-08-02 18:13:29 UTC) #2
Cutch
lgtm
4 years, 4 months ago (2016-08-02 18:34:30 UTC) #3
rmacnak
4 years, 4 months ago (2016-08-02 22:14:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cdae2f2783c5fc0661c8aa385105070c147b5482 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698