Issue 220193007: Make it possible to use HeapType inside objects-inl.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220193007: Make it possible to use HeapType inside objects-inl.h. (Closed)

Created:
6 years, 8 months ago by Benedikt Meurer

Modified:
6 years, 8 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+440 lines, -237 lines)			Patch
M	src/types.h	View	5 chunks	+61 lines, -208 lines	0 comments	Download
M	src/types.cc	View	2 chunks	+5 lines, -27 lines	0 comments	Download
A	src/types-inl.h	View	1 chunk	+370 lines, -0 lines	0 comments	Download
M	src/v8.h	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	src/v8globals.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

rossberg

Main comment: move ZoneTypeConfig impl to types-inl.h as well, to be consistent.

6 years, 8 months ago (2014-04-01 08:46:12 UTC) #2

Benedikt Meurer

On 2014/04/01 08:46:12, rossberg wrote: > Main comment: move ZoneTypeConfig impl to types-inl.h as well, ...

6 years, 8 months ago (2014-04-01 10:36:55 UTC) #3

Benedikt Meurer

6 years, 8 months ago (2014-04-01 11:07:18 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20390 (presubmit successful).