Win DirectShow: connect antibanding/anti-flicker where supported.

media/video/capture/win/video_capture_device_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/win/video_capture_device_win.h"
 
+#include <ks.h>
+#include <ksmedia.h>
+
 #include <algorithm>
 #include <list>
 
 #include "base/command_line.h"
 #include "base/strings/string_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/win/metro.h"
 #include "base/win/scoped_co_mem.h"
 #include "base/win/scoped_variant.h"
 #include "base/win/windows_version.h"
@@ skipping 567 matching lines @@
       hr = graph_builder_->AddFilter(mjpg_filter_, NULL);
     }
 
     if (FAILED(hr)) {
       mjpg_filter_.Release();
       input_mjpg_pin_.Release();
       output_mjpg_pin_.Release();
     }
   }
 
+  SetAntiFlickerInCaptureFilter();
+
   if (format.pixel_format == PIXEL_FORMAT_MJPEG && mjpg_filter_.get()) {
     // Connect the camera to the MJPEG decoder.
     hr = graph_builder_->ConnectDirect(output_capture_pin_, input_mjpg_pin_,
                                        NULL);
     // Connect the MJPEG filter to the Capture filter.
     hr += graph_builder_->ConnectDirect(output_mjpg_pin_, input_sink_pin_,
                                         NULL);
   } else {
     hr = graph_builder_->ConnectDirect(output_capture_pin_, input_sink_pin_,
                                        NULL);
@@ skipping 138 matching lines @@
 
       capability.supported_format.pixel_format =
           TranslateMediaSubtypeToPixelFormat(media_type->subtype);
       capabilities_.Add(capability);
     }
   }
 
   return !capabilities_.empty();
 }
 
+// Set the power line frequency removal in |capture_filter_| if available.
+void VideoCaptureDeviceWin::SetAntiFlickerInCaptureFilter() {
+  HRESULT hr;

[tommi (sloooow) - chröme, 2014/04/22 14:55:27]

nit: define where you need it

[mcasas, 2014/04/23 17:04:46]

Done.

+  const int power_line_frequency = GetPowerLineFrequencyForLocation();
+  if (power_line_frequency == kPowerLine50Hz ||
+      power_line_frequency == kPowerLine60Hz) {

[tommi (sloooow) - chröme, 2014/04/22 14:55:27]

nit: could also turn this into an early return to reduce the number of scopes.

if (power_line_frequency != kPowerLine50Hz &&
    power_line_frequency != kPowerLine60Hz) {
  return;
}

...

[mcasas, 2014/04/23 17:04:46]

Done.

+    ScopedComPtr<IKsPropertySet> ks_propset;
+    DWORD type_support = 0;
+    if (SUCCEEDED(hr = ks_propset.QueryFrom(capture_filter_)) &&
+        SUCCEEDED(hr = ks_propset->QuerySupported(PROPSETID_VIDCAP_VIDEOPROCAMP,
+                           KSPROPERTY_VIDEOPROCAMP_POWERLINE_FREQUENCY,

[tommi (sloooow) - chröme, 2014/04/22 14:55:27]

not sure about this indent... think it should be:

SUCCEEDED(...
    KSPROPERTY_...

[mcasas, 2014/04/23 17:04:46]

Done.

+                           &type_support)) &&
+        (type_support & KSPROPERTY_SUPPORT_SET)) {
+      KSPROPERTY_VIDEOPROCAMP_S data = {};
+      data.Property.Set = PROPSETID_VIDCAP_VIDEOPROCAMP;
+      data.Property.Id = KSPROPERTY_VIDEOPROCAMP_POWERLINE_FREQUENCY;
+      data.Property.Flags = KSPROPERTY_TYPE_SET;
+      data.Value = (power_line_frequency == kPowerLine50Hz) ? 1 : 2;
+      data.Flags = KSPROPERTY_VIDEOPROCAMP_FLAGS_MANUAL;
+      hr = ks_propset->Set(PROPSETID_VIDCAP_VIDEOPROCAMP,
+                           KSPROPERTY_VIDEOPROCAMP_POWERLINE_FREQUENCY,
+                           &data, sizeof(data), &data, sizeof(data));
+      DVLOG_IF(2, FAILED(hr)) << "Anti-flicker setting failed.";

[tommi (sloooow) - chröme, 2014/04/22 14:55:27]

DLOG_IF(ERROR, FAILED(hr)) ?

[mcasas, 2014/04/23 17:04:46]

Done.

+      DVLOG_IF(2, SUCCEEDED(hr)) << "Anti-flicker set correctly.";
+    } else {
+      DVLOG(2) << "Anti-flicker setting not supported.";
+    }
+  }
+}
+
 void VideoCaptureDeviceWin::SetErrorState(const std::string& reason) {
   DCHECK(CalledOnValidThread());
   DVLOG(1) << reason;
   state_ = kError;
   client_->OnError(reason);
 }
 }  // namespace media