Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 220193003: Style changes shouldn't cause RenderLayerCompositor to rebuild its tree (Closed)

Created:
6 years, 8 months ago by abarth-chromium
Modified:
6 years, 8 months ago
Reviewers:
esprehn, ojan
CC:
blink-reviews, bemjb+rendering_chromium.org, dsinclair, zoltan1, eae+blinkwatch, leviw+renderwatch, abarth-chromium, jchaffraix+rendering, pdr., rune+blink, ojan, Ian Vollick
Visibility:
Public.

Description

Style changes shouldn't cause RenderLayerCompositor to rebuild its tree Before this CL, if you changed the style on a RenderLayer that was directly composited, we would trigger a rebuild of the entire compositing tree as part of the "chicken-egg hacks." There's no reason for that. Instead, we simply need to do a geometry update after changing style. This makes the compositing update in the calculator faster by 7%. R=ojan@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170515

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
abarth-chromium
I need to measure exactly how much this change saves us on the calculator.
6 years, 8 months ago (2014-04-01 00:47:41 UTC) #1
ojan
lgtm
6 years, 8 months ago (2014-04-01 01:03:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220193003/1
6 years, 8 months ago (2014-04-01 01:03:49 UTC) #3
abarth-chromium
The CQ bit was unchecked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 01:09:06 UTC) #4
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 01:15:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220193003/1
6 years, 8 months ago (2014-04-01 01:16:19 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 01:38:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-01 01:38:17 UTC) #8
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 01:55:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220193003/1
6 years, 8 months ago (2014-04-01 01:55:19 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 02:20:18 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 02:20:18 UTC) #12
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 02:21:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220193003/1
6 years, 8 months ago (2014-04-01 02:21:17 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 03:30:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 03:30:05 UTC) #16
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 8 months ago (2014-04-01 04:29:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/abarth@chromium.org/220193003/1
6 years, 8 months ago (2014-04-01 04:29:52 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 05:01:20 UTC) #19
Message was sent while issue was closed.
Change committed as 170515

Powered by Google App Engine
This is Rietveld 408576698