Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2201923002: android: Swallow PopupWindow exception from android (Closed)

Created:
4 years, 4 months ago by boliu
Modified:
4 years, 4 months ago
CC:
amaralp, chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Swallow PopupWindow exception from android This is a workaround for Android L bug with PopupWindow. BUG=633224 Committed: https://crrev.com/6b694e053f5e2a39adae517e668c8402045529b6 Cr-Commit-Position: refs/heads/master@{#409077}

Patch Set 1 #

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
boliu
I don't see any bug with our code, so can't do much except just catch ...
4 years, 4 months ago (2016-08-01 20:17:36 UTC) #2
aelias_OOO_until_Jul13
lgtm
4 years, 4 months ago (2016-08-01 20:55:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201923002/20001
4 years, 4 months ago (2016-08-01 20:58:11 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-01 22:36:35 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 22:41:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6b694e053f5e2a39adae517e668c8402045529b6
Cr-Commit-Position: refs/heads/master@{#409077}

Powered by Google App Engine
This is Rietveld 408576698