Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2201913002: DevTools: [Console] revert filtering out URLs from %c styling properties (Closed)

Created:
4 years, 4 months ago by lushnikov
Modified:
4 years, 4 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [Console] revert filtering out URLs from %c styling properties The patch reverts logic which filters URL's from %c styling properties. (which was added in crrev.com/1191983002) The motivation behind this current implementation is naive and doesn't address the issue. BUG=495643 R=dgozman Committed: https://crrev.com/d406a9cd13b766082e18656d38af20463150bde0 Cr-Commit-Position: refs/heads/master@{#409059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-format-style-whitelist.html View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-format-style-whitelist-expected.txt View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lushnikov
please, take a look
4 years, 4 months ago (2016-08-01 19:56:19 UTC) #1
dgozman
Reverting a bad fix is a good thing! lgtm
4 years, 4 months ago (2016-08-01 20:00:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201913002/1
4 years, 4 months ago (2016-08-01 20:10:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-01 21:24:11 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-01 21:29:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d406a9cd13b766082e18656d38af20463150bde0
Cr-Commit-Position: refs/heads/master@{#409059}

Powered by Google App Engine
This is Rietveld 408576698