Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 2201893007: Roll chromium_revision 0868029..33f8768 (Closed)

Created:
4 years, 4 months ago by kjellander_chromium
Modified:
4 years, 4 months ago
Reviewers:
fbarchard, fbarchard1
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Roll chromium_revision 0868029..33f8768 Add a lot of new dependencies for the Android toolchain to setup_links.py (added for WebRTC in https://codereview.webrtc.org/2190893002 and https://codereview.webrtc.org/2215633002). There was no other way to get the Android test to build than renaming the APK to yuv_unittests. That made it possible to use build/apk_test.gypi (there's some bug somewhere that assumes names doesn't start with "lib", see http://crbug.com/543820). TBR=fbarchard@chromium.org BUG=libyuv:626 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/d19f1c319a49a2e9f3b2bf07b0ebccfcc1e49380

Patch Set 1 : Roll chromium_revision 0868029..33f8768 #

Patch Set 2 : Updated documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -43 lines) Patch
M .gitignore View 2 chunks +10 lines, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build_overrides/build.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M docs/getting_started.md View 1 1 chunk +9 lines, -9 lines 0 comments Download
M libyuv.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M libyuv_test.gyp View 1 chunk +5 lines, -29 lines 0 comments Download
M setup_links.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_chromium
I successfully executed the test on Android: $ out/Release/bin/run_yuv_unittest W 0.042s Main No isolate file ...
4 years, 4 months ago (2016-08-04 08:05:35 UTC) #5
kjellander_chromium
landing this assuming you're fine with the annoying (but I don't see any other way) ...
4 years, 4 months ago (2016-08-04 11:42:59 UTC) #6
kjellander_chromium
Committed patchset #2 (id:40001) manually as d19f1c319a49a2e9f3b2bf07b0ebccfcc1e49380 (presubmit successful).
4 years, 4 months ago (2016-08-04 11:43:25 UTC) #8
fbarchard1
lgtm!
4 years, 4 months ago (2016-08-04 22:30:13 UTC) #10
fbarchard1
On 2016/08/04 22:30:13, fbarchard1 wrote: > lgtm! lgtm for the code review. But awesome!
4 years, 4 months ago (2016-08-04 22:30:47 UTC) #11
fbarchard1
4 years, 4 months ago (2016-08-04 22:30:49 UTC) #12
Message was sent while issue was closed.
On 2016/08/04 22:30:13, fbarchard1 wrote:
> lgtm!

lgtm for the code review.  But awesome!

Powered by Google App Engine
This is Rietveld 408576698