Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing aura problems Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 3362aecf01defdbf2d288f7b99bfb11d20ade97f..69d10ec3494ceb9a05ba6b6c7c1318fd6d095616 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -1097,7 +1097,7 @@ void RenderWidgetHostViewAura::OnSwapCompositorFrame(
delegated_frame_host_->SwapDelegatedFrame(output_surface_id,
std::move(frame));
SelectionUpdated(selection.is_editable, selection.is_empty_text_form_control,
- selection.start, selection.end);
+ selection.is_handle_visible, selection.start, selection.end);
}
void RenderWidgetHostViewAura::ClearCompositorFrame() {
@@ -2762,11 +2762,13 @@ void RenderWidgetHostViewAura::ForwardKeyboardEvent(
void RenderWidgetHostViewAura::SelectionUpdated(
bool is_editable,
bool is_empty_text_form_control,
+ bool is_handle_visible,
const gfx::SelectionBound& start,
const gfx::SelectionBound& end) {
selection_controller_->OnSelectionEditable(is_editable);
selection_controller_->OnSelectionEmpty(is_empty_text_form_control);
- selection_controller_->OnSelectionBoundsChanged(start, end);
+ selection_controller_->OnSelectionBoundsChanged(
+ start, end, is_handle_visible);
}
void RenderWidgetHostViewAura::CreateSelectionController() {

Powered by Google App Engine
This is Rietveld 408576698