Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed incorrect rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index eb6449f0c8996436534491c40ce5542f4c6c6d3e..6cd8721519cdb1180aab3f3ed001bbfe9164fed9 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -933,8 +933,8 @@ void RenderWidgetHostViewAura::OnSwapCompositorFrame(
delegated_frame_host_->SwapDelegatedFrame(compositor_frame_sink_id,
std::move(frame));
}
- SelectionUpdated(selection.is_editable, selection.is_empty_text_form_control,
- selection.start, selection.end);
+ selection_controller_->OnSelectionBoundsChanged(selection.start,
+ selection.end);
}
void RenderWidgetHostViewAura::ClearCompositorFrame() {
@@ -2243,16 +2243,6 @@ void RenderWidgetHostViewAura::ForwardKeyboardEvent(
target_host->ForwardKeyboardEvent(event);
}
-void RenderWidgetHostViewAura::SelectionUpdated(
- bool is_editable,
- bool is_empty_text_form_control,
- const gfx::SelectionBound& start,
- const gfx::SelectionBound& end) {
- selection_controller_->OnSelectionEditable(is_editable);
- selection_controller_->OnSelectionEmpty(is_empty_text_form_control);
- selection_controller_->OnSelectionBoundsChanged(start, end);
-}
-
void RenderWidgetHostViewAura::CreateSelectionController() {
ui::TouchSelectionController::Config tsc_config;
tsc_config.max_tap_duration = base::TimeDelta::FromMilliseconds(

Powered by Google App Engine
This is Rietveld 408576698