Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: third_party/WebKit/Source/core/editing/VisibleSelection.h

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: default handle visibility should be false Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/VisibleSelection.h
diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h
index 176f2317f1aa6696767a8a5808c93eea06a2757f..8a5544c1d0736b9249ee4c4326ac89325302ffa1 100644
--- a/third_party/WebKit/Source/core/editing/VisibleSelection.h
+++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h
@@ -50,11 +50,11 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate {
public:
VisibleSelectionTemplate();
VisibleSelectionTemplate(const PositionTemplate<Strategy>&, TextAffinity, bool isDirectional = false);
- VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SelDefaultAffinity, bool isDirectional = false);
+ VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SelDefaultAffinity, bool isDirectional = false, bool isHandleVisible = false);
explicit VisibleSelectionTemplate(const EphemeralRangeTemplate<Strategy>&, TextAffinity = SelDefaultAffinity, bool isDirectional = false);
explicit VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, bool isDirectional = false);
- VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, const VisiblePositionTemplate<Strategy>&, bool isDirectional = false);
+ VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, const VisiblePositionTemplate<Strategy>&, bool isDirectional = false, bool isHandleVisible = false);
explicit VisibleSelectionTemplate(const PositionWithAffinityTemplate<Strategy>&, bool isDirectional = false);
@@ -65,6 +65,9 @@ public:
SelectionType getSelectionType() const { return m_selectionType; }
+ void setIsHandleVisible(bool isHandleVisible) { m_isHandleVisible = isHandleVisible; }
+ bool isHandleVisible() const { return m_isHandleVisible; }
+
void setAffinity(TextAffinity affinity) { m_affinity = affinity; }
TextAffinity affinity() const { return m_affinity; }
@@ -172,6 +175,7 @@ private:
// TODO(yosin): Once we unify start/end and base/extent, we should get rid
// of |m_hasTrailingWhitespace|.
bool m_hasTrailingWhitespace : 1;
+ bool m_isHandleVisible : 1;
};
extern template class CORE_EXTERN_TEMPLATE_EXPORT VisibleSelectionTemplate<EditingStrategy>;

Powered by Google App Engine
This is Rietveld 408576698