third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: default handle visibility should be false Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp b/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

index c42794ae2725129809ecd971e69d0d99d56d0200..b067205788e318638e1f095dfbf2953dedf54016 100644

--- a/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

@@ -171,6 +171,7 @@ void SelectionAdjuster::adjustSelectionInFlatTree(VisibleSelectionInFlatTree* se

selectionInFlatTree->m_isDirectional = selection.m_isDirectional;

selectionInFlatTree->m_granularity = selection.m_granularity;

selectionInFlatTree->m_hasTrailingWhitespace = selection.m_hasTrailingWhitespace;

+ selectionInFlatTree->m_isHandleVisible = selection.m_isHandleVisible;

selectionInFlatTree->m_baseIsFirst = base.isNull() || base.compareTo(extent) <= 0;

if (position1.compareTo(position2) <= 0) {

selectionInFlatTree->m_start = position1;

@@ -215,6 +216,7 @@ void SelectionAdjuster::adjustSelectionInDOMTree(VisibleSelection* selection, co

selection->m_isDirectional = selectionInFlatTree.m_isDirectional;

selection->m_granularity = selectionInFlatTree.m_granularity;

selection->m_hasTrailingWhitespace = selectionInFlatTree.m_hasTrailingWhitespace;

+ selection->m_isHandleVisible = selectionInFlatTree.m_isHandleVisible;

selection->m_baseIsFirst = base.isNull() || base.compareTo(extent) <= 0;

if (position1.compareTo(position2) <= 0) {

selection->m_start = position1;