content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: default handle visibility should be false Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_impl.cc ('K') | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index f07285b3f08ac05c764048b5942832008cad3829..92a04011a8d631ce49fdd170d7b4dee71670827b 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2363,9 +2363,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

}

mWasPastePopupShowingOnInsertionDragStart = false;

break;

- case SelectionEventType.SELECTION_ESTABLISHED:

- case SelectionEventType.SELECTION_DISSOLVED:

- break;

default:

assert false : "Invalid selection event type.";

@@ -3531,9 +3528,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

private native void nativePinchBy(long nativeContentViewCoreImpl, long timeMs,

float anchorX, float anchorY, float deltaScale);

- private native void nativeSelectBetweenCoordinates(

- long nativeContentViewCoreImpl, float x1, float y1, float x2, float y2);

private native void nativeDismissTextHandles(long nativeContentViewCoreImpl);

private native void nativeSetTextHandlesTemporarilyHidden(

long nativeContentViewCoreImpl, boolean hidden);