Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: content/browser/renderer_host/input/stylus_text_selector.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: default handle visibility should be false Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/stylus_text_selector.cc
diff --git a/content/browser/renderer_host/input/stylus_text_selector.cc b/content/browser/renderer_host/input/stylus_text_selector.cc
index 5af89606c47af2a4c6a54a998d640ebcacf15cd1..621355b4ed4cc9eb63aabca6ef423fe212a920e8 100644
--- a/content/browser/renderer_host/input/stylus_text_selector.cc
+++ b/content/browser/renderer_host/input/stylus_text_selector.cc
@@ -40,7 +40,6 @@ StylusTextSelector::StylusTextSelector(StylusTextSelectorClient* client)
text_selection_triggered_(false),
secondary_button_pressed_(false),
dragging_(false),
- dragged_(false),
anchor_x_(0.0f),
anchor_y_(0.0f) {
DCHECK(client);
@@ -64,7 +63,6 @@ bool StylusTextSelector::OnTouchEvent(const MotionEvent& event) {
switch (event.GetAction()) {
case MotionEvent::ACTION_DOWN:
dragging_ = false;
- dragged_ = false;
anchor_x_ = event.GetX();
anchor_y_ = event.GetY();
break;
@@ -79,9 +77,6 @@ bool StylusTextSelector::OnTouchEvent(const MotionEvent& event) {
case MotionEvent::ACTION_UP:
case MotionEvent::ACTION_CANCEL:
- if (dragged_)
- client_->OnStylusSelectEnd();
- dragged_ = false;
dragging_ = false;
break;
@@ -123,7 +118,6 @@ bool StylusTextSelector::OnScroll(const MotionEvent& e1,
if (!dragging_) {
dragging_ = true;
- dragged_ = true;
client_->OnStylusSelectBegin(anchor_x_, anchor_y_, e2.GetX(), e2.GetY());
} else {
client_->OnStylusSelectUpdate(e2.GetX(), e2.GetY());

Powered by Google App Engine
This is Rietveld 408576698