content/browser/android/content_view_core_impl.cc - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/content_view_core_impl.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: default handle visibility should be false Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/android/content_view_core_impl.cc

diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc

index 108ecdec73adf1364a3297863d1a430026d96620..89b8f8eabb170f0a6b166ac3abb19ed64e89a024 100644

--- a/content/browser/android/content_view_core_impl.cc

+++ b/content/browser/android/content_view_core_impl.cc

@@ -1207,17 +1207,6 @@ void ContentViewCoreImpl::PinchBy(JNIEnv* env,

SendGestureEvent(event);

}

-void ContentViewCoreImpl::SelectBetweenCoordinates(

- JNIEnv* env,

- const JavaParamRef<jobject>& obj,

- jfloat x1,

- jfloat y1,

- jfloat x2,

- jfloat y2) {

- SelectBetweenCoordinates(gfx::PointF(x1 / dpi_scale(), y1 / dpi_scale()),

- gfx::PointF(x2 / dpi_scale(), y2 / dpi_scale()));

void ContentViewCoreImpl::DismissTextHandles(JNIEnv* env,

const JavaParamRef<jobject>& obj) {

RenderWidgetHostViewAndroid* rwhv = GetRenderWidgetHostViewAndroid();