Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: default handle visibility should be false Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
index 9f56db3a1b313797a79e176daa83292955029fa8..299ecc34e937f17e071a05a8b7109c6720876006 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java
@@ -68,7 +68,6 @@ public class ContextualSearchSelectionController {
// Reflects whether the last tap was valid and whether we still have a tap-based selection.
private ContextualSearchTapState mLastTapState;
private boolean mIsWaitingForInvalidTapDetection;
- private boolean mIsSelectionEstablished;
private boolean mShouldHandleSelectionModification;
private boolean mDidExpandSelection;
@@ -295,12 +294,6 @@ public class ContextualSearchSelectionController {
case SelectionEventType.SELECTION_HANDLE_DRAG_STOPPED:
shouldHandleSelection = mShouldHandleSelectionModification;
break;
- case SelectionEventType.SELECTION_ESTABLISHED:
- mIsSelectionEstablished = true;
- break;
- case SelectionEventType.SELECTION_DISSOLVED:
- mIsSelectionEstablished = false;
- break;
default:
}
@@ -510,14 +503,6 @@ public class ContextualSearchSelectionController {
}
/**
- * @return whether the selection has been established, for testing.
- */
- @VisibleForTesting
- boolean isSelectionEstablished() {
- return mIsSelectionEstablished;
- }
-
- /**
* Evaluates whether the given selection is valid and notifies the handler about potential
* selection suppression.
* TODO(pedrosimonetti): substitute this once the system supports suppressing selections.

Powered by Google App Engine
This is Rietveld 408576698