third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing clear handles Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

diff --git a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

index 891f0d46ba890dd4a8b5d8c54ad405643bde8ef5..0c8bd0d6585b5ce78a1efb2652aed86b66ae0503 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

+++ b/third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp

@@ -304,7 +304,8 @@ void SelectionControllerTest::setNonDirectionalSelectionIfNeeded(

.eventHandler()

.selectionController()

.setNonDirectionalSelectionIfNeeded(

- newSelection, granularity, SelectionController::DoNotAdjustEndpoints);

+ newSelection, granularity, SelectionController::DoNotAdjustEndpoints,

+ HandleVisibility::NotVisible);

}

// TODO(yosin): We should move this test to "SelectionControllerTest.cpp"