third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixing clear handles Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html ('k') | third_party/WebKit/Source/core/editing/FrameSelection.h » ('j') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

diff --git a/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html b/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

index 1614a33d22fd4eab166c77c0bfac00dd3a425d42..d9daa8630df4552b37975791c3163e14d0294722 100644

--- a/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

+++ b/third_party/WebKit/LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

@@ -10,7 +10,6 @@ async_test(function(t) {

return;

}

doSetSelectionRange('focus');

- doSetSelectionRange('mousedown');

doSetSelectionRange('mouseup');

doSetSelectionRange('click');

t.done();

@@ -26,13 +25,8 @@ async_test(function(t) {

eventSender.gestureTapDown(tx, ty);

eventSender.gestureShowPress(tx, ty);

eventSender.gestureTap(tx, ty);

- if (eventType === 'mousedown') {

- assert_equals(textfield.selectionStart, 0);

- assert_equals(textfield.selectionEnd, 0);

- } else {

- assert_equals(textfield.selectionStart, 0);

- assert_equals(textfield.selectionEnd, 5);

- }

+ assert_equals(textfield.selectionStart, 0);

+ assert_equals(textfield.selectionEnd, 5);

textfield.setSelectionRange(0, 0);

textfield.removeEventListener(eventType, setSelectionRange);

}