third_party/WebKit/Source/core/layout/HitTestResult.cpp - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/HitTestResult.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout test doesnt make sense because tap causes selections handles to be shown Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/HitTestResult.cpp

diff --git a/third_party/WebKit/Source/core/layout/HitTestResult.cpp b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

index 51e0fd88c3ff825195f8cd7064d38816ed04619d..13f15f7109e42a31d230217984dfac8c16562aa4 100644

--- a/third_party/WebKit/Source/core/layout/HitTestResult.cpp

+++ b/third_party/WebKit/Source/core/layout/HitTestResult.cpp

@@ -231,7 +231,7 @@ bool HitTestResult::isSelected() const {

return false;

if (LocalFrame* frame = m_innerNode->document().frame())

- return frame->selection().contains(m_hitTestLocation.point());

+ return frame->selection().contains(*this);

return false;

}