content/browser/renderer_host/input/touch_selection_controller_client_aura.cc - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: layout test doesnt make sense because tap causes selections handles to be shown Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java ('k') | content/browser/renderer_host/input/touch_selection_controller_client_aura_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

diff --git a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

index 1bf91a5447060e31afbc5159cc7474d592c4993d..16978aeec963f3d2639bb5d9511adc3d3f240cca 100644

--- a/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

+++ b/content/browser/renderer_host/input/touch_selection_controller_client_aura.cc

@@ -157,7 +157,8 @@ void TouchSelectionControllerClientAura::OnScrollCompleted() {

bool TouchSelectionControllerClientAura::HandleContextMenu(

const ContextMenuParams& params) {

if (params.source_type == ui::MENU_SOURCE_LONG_PRESS &&

- rwhva_->selection_controller()->insertion_active_or_requested() &&

+ (rwhva_->selection_controller()->active_status() ==

+ ui::TouchSelectionController::INSERTION_ACTIVE) &&

IsQuickMenuAvailable()) {

DCHECK(params.is_editable);

DCHECK(params.selection_text.empty());

@@ -300,9 +301,6 @@ void TouchSelectionControllerClientAura::OnSelectionEvent(

quick_menu_requested_ = !quick_menu_requested_;

UpdateQuickMenu();

break;

- case ui::SELECTION_ESTABLISHED:

- case ui::SELECTION_DISSOLVED:

- break;

};

}