content/browser/renderer_host/render_widget_host_view_android.h - Issue 2201853002: Blink handle selection handle visibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: try running even rebaseline tests Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 573d4313b8e22eac2343af45d39cca956158830a..569e972a71a5a69bcf068cc4b88dc47072b462a2 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -191,7 +191,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

// StylusTextSelectorClient implementation.

void OnStylusSelectBegin(float x0, float y0, float x1, float y1) override;

void OnStylusSelectUpdate(float x, float y) override;

- void OnStylusSelectEnd() override;

aelias_OOO_until_Jul13 2016/10/07 02:40:20 I think it's fine to keep the base class method an

amaralp 2016/10/14 00:53:07 Done.

void OnStylusSelectTap(base::TimeTicks time, float x, float y) override;

// ui::TouchSelectionControllerClient implementation.