Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1328)

Unified Diff: content/browser/renderer_host/input/stylus_text_selector_unittest.cc

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try running even rebaseline tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/stylus_text_selector_unittest.cc
diff --git a/content/browser/renderer_host/input/stylus_text_selector_unittest.cc b/content/browser/renderer_host/input/stylus_text_selector_unittest.cc
index 887b4c23819ce45311e4cc44eec41ac78a9edb7c..4a98c7991d0735e86ed99da34b7eb40d5452d9dc 100644
--- a/content/browser/renderer_host/input/stylus_text_selector_unittest.cc
+++ b/content/browser/renderer_host/input/stylus_text_selector_unittest.cc
@@ -50,8 +50,6 @@ class StylusTextSelectorTest : public testing::Test,
event_log_.push_back(ss.str());
}
- void OnStylusSelectEnd() override { event_log_.push_back("End"); }
-
void OnStylusSelectTap(base::TimeTicks time, float x, float y) override {
event_log_.push_back("Tap");
}
@@ -144,8 +142,7 @@ TEST_F(StylusTextSelectorTest, PenDragging) {
action_up.SetToolType(0, MotionEvent::TOOL_TYPE_STYLUS);
action_up.set_button_state(0);
EXPECT_TRUE(selector_->OnTouchEvent(action_up));
- ASSERT_EQ(3u, event_log_.size()); // NO CHANGE
- EXPECT_STREQ("End", event_log_.back().c_str());
+ ASSERT_EQ(2u, event_log_.size()); // NO CHANGE
}
TEST_F(StylusTextSelectorTest, PenDraggingButtonNotPressed) {
@@ -209,8 +206,7 @@ TEST_F(StylusTextSelectorTest, PenDraggingButtonNotPressed) {
action_up.SetToolType(0, MotionEvent::TOOL_TYPE_STYLUS);
action_up.set_button_state(0);
EXPECT_TRUE(selector_->OnTouchEvent(action_up));
- EXPECT_EQ(3u, event_log_.size());
- EXPECT_STREQ("End", event_log_.back().c_str());
+ EXPECT_EQ(2u, event_log_.size()); // NO CHANGE
}
TEST_F(StylusTextSelectorTest, TapTriggersLongPressSelection) {

Powered by Google App Engine
This is Rietveld 408576698