Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixing aura problems Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1689 matching lines...) Expand 10 before | Expand all | Expand 10 after
1700 renderedEnd.positionInGraphicsLayerBacking(selection.end, false); 1700 renderedEnd.positionInGraphicsLayerBacking(selection.end, false);
1701 if (!selection.end.layer) 1701 if (!selection.end.layer)
1702 return false; 1702 return false;
1703 1703
1704 selection.type = visibleSelection.getSelectionType(); 1704 selection.type = visibleSelection.getSelectionType();
1705 selection.isEditable = visibleSelection.isContentEditable(); 1705 selection.isEditable = visibleSelection.isContentEditable();
1706 if (selection.isEditable) { 1706 if (selection.isEditable) {
1707 if (HTMLTextFormControlElement* enclosingTextFormControlElement = enclos ingTextFormControl(visibleSelection.rootEditableElement())) 1707 if (HTMLTextFormControlElement* enclosingTextFormControlElement = enclos ingTextFormControl(visibleSelection.rootEditableElement()))
1708 selection.isEmptyTextFormControl = enclosingTextFormControlElement-> value().isEmpty(); 1708 selection.isEmptyTextFormControl = enclosingTextFormControlElement-> value().isEmpty();
1709 } 1709 }
1710 selection.isHandleVisible = visibleSelection.isHandleVisible();
1710 selection.start.isTextDirectionRTL |= primaryDirectionOf(*visibleSelection.s tart().anchorNode()) == RTL; 1711 selection.start.isTextDirectionRTL |= primaryDirectionOf(*visibleSelection.s tart().anchorNode()) == RTL;
1711 selection.end.isTextDirectionRTL |= primaryDirectionOf(*visibleSelection.end ().anchorNode()) == RTL; 1712 selection.end.isTextDirectionRTL |= primaryDirectionOf(*visibleSelection.end ().anchorNode()) == RTL;
1712 1713
1713 return true; 1714 return true;
1714 } 1715 }
1715 1716
1716 void FrameView::updateCompositedSelectionIfNeeded() 1717 void FrameView::updateCompositedSelectionIfNeeded()
1717 { 1718 {
1718 if (!RuntimeEnabledFeatures::compositedSelectionUpdateEnabled()) 1719 if (!RuntimeEnabledFeatures::compositedSelectionUpdateEnabled())
1719 return; 1720 return;
(...skipping 2556 matching lines...) Expand 10 before | Expand all | Expand 10 after
4276 } 4277 }
4277 4278
4278 bool FrameView::canThrottleRendering() const 4279 bool FrameView::canThrottleRendering() const
4279 { 4280 {
4280 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4281 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4281 return false; 4282 return false;
4282 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling); 4283 return m_subtreeThrottled || (m_hiddenForThrottling && m_crossOriginForThrot tling);
4283 } 4284 }
4284 4285
4285 } // namespace blink 4286 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698