Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed incorrect rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1940 matching lines...) Expand 10 before | Expand all | Expand 10 after
1951 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1951 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1952 } 1952 }
1953 } 1953 }
1954 1954
1955 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1955 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1956 CompositedSelection& selection) { 1956 CompositedSelection& selection) {
1957 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1957 if (!frame.view() || frame.view()->shouldThrottleRendering())
1958 return false; 1958 return false;
1959 1959
1960 const VisibleSelection& visibleSelection = frame.selection().selection(); 1960 const VisibleSelection& visibleSelection = frame.selection().selection();
1961 if (visibleSelection.isNone()) 1961 if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
1962 return false; 1962 return false;
1963 1963
1964 // Non-editable caret selections lack any kind of UI affordance, and 1964 // Non-editable caret selections lack any kind of UI affordance, and
1965 // needn't be tracked by the client. 1965 // needn't be tracked by the client.
1966 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1966 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1967 return false; 1967 return false;
1968 1968
1969 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1969 VisiblePosition visibleStart(visibleSelection.visibleStart());
1970 RenderedPosition renderedStart(visibleStart); 1970 RenderedPosition renderedStart(visibleStart);
1971 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1971 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 3014 matching lines...) Expand 10 before | Expand all | Expand 10 after
4986 // This is the top-level frame, so no mapping necessary. 4986 // This is the top-level frame, so no mapping necessary.
4987 if (m_frame->isMainFrame()) 4987 if (m_frame->isMainFrame())
4988 return; 4988 return;
4989 4989
4990 LayoutRect viewportIntersectionRect(remoteViewportIntersection()); 4990 LayoutRect viewportIntersectionRect(remoteViewportIntersection());
4991 transformState.move( 4991 transformState.move(
4992 LayoutSize(-viewportIntersectionRect.x(), -viewportIntersectionRect.y())); 4992 LayoutSize(-viewportIntersectionRect.x(), -viewportIntersectionRect.y()));
4993 } 4993 }
4994 4994
4995 } // namespace blink 4995 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698