Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1936 matching lines...) Expand 10 before | Expand all | Expand 10 after
1947 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1947 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1948 } 1948 }
1949 } 1949 }
1950 1950
1951 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1951 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1952 CompositedSelection& selection) { 1952 CompositedSelection& selection) {
1953 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1953 if (!frame.view() || frame.view()->shouldThrottleRendering())
1954 return false; 1954 return false;
1955 1955
1956 const VisibleSelection& visibleSelection = frame.selection().selection(); 1956 const VisibleSelection& visibleSelection = frame.selection().selection();
1957 if (visibleSelection.isNone()) 1957 if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
1958 return false; 1958 return false;
1959 1959
1960 // Non-editable caret selections lack any kind of UI affordance, and 1960 // Non-editable caret selections lack any kind of UI affordance, and
1961 // needn't be tracked by the client. 1961 // needn't be tracked by the client.
1962 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1962 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1963 return false; 1963 return false;
1964 1964
1965 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1965 VisiblePosition visibleStart(visibleSelection.visibleStart());
1966 RenderedPosition renderedStart(visibleStart); 1966 RenderedPosition renderedStart(visibleStart);
1967 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1967 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 2945 matching lines...) Expand 10 before | Expand all | Expand 10 after
4913 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount; 4913 reason < MainThreadScrollingReason::kMainThreadScrollingReasonCount;
4914 ++reason) { 4914 ++reason) {
4915 if (m_mainThreadScrollingReasonsCounter[reason] > 0) { 4915 if (m_mainThreadScrollingReasonsCounter[reason] > 0) {
4916 reasons |= 1 << reason; 4916 reasons |= 1 << reason;
4917 } 4917 }
4918 } 4918 }
4919 return reasons; 4919 return reasons;
4920 } 4920 }
4921 4921
4922 } // namespace blink 4922 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698