Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixed line length Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1873 matching lines...) Expand 10 before | Expand all | Expand 10 after
1884 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1884 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1885 } 1885 }
1886 } 1886 }
1887 1887
1888 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1888 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1889 CompositedSelection& selection) { 1889 CompositedSelection& selection) {
1890 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1890 if (!frame.view() || frame.view()->shouldThrottleRendering())
1891 return false; 1891 return false;
1892 1892
1893 const VisibleSelection& visibleSelection = frame.selection().selection(); 1893 const VisibleSelection& visibleSelection = frame.selection().selection();
1894 if (visibleSelection.isNone()) 1894 if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
1895 return false; 1895 return false;
1896 1896
1897 // Non-editable caret selections lack any kind of UI affordance, and 1897 // Non-editable caret selections lack any kind of UI affordance, and
1898 // needn't be tracked by the client. 1898 // needn't be tracked by the client.
1899 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1899 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1900 return false; 1900 return false;
1901 1901
1902 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1902 VisiblePosition visibleStart(visibleSelection.visibleStart());
1903 RenderedPosition renderedStart(visibleStart); 1903 RenderedPosition renderedStart(visibleStart);
1904 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1904 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 2742 matching lines...) Expand 10 before | Expand all | Expand 10 after
4647 DCHECK(m_frame->isMainFrame()); 4647 DCHECK(m_frame->isMainFrame());
4648 return m_initialViewportSize.width(); 4648 return m_initialViewportSize.width();
4649 } 4649 }
4650 4650
4651 int FrameView::initialViewportHeight() const { 4651 int FrameView::initialViewportHeight() const {
4652 DCHECK(m_frame->isMainFrame()); 4652 DCHECK(m_frame->isMainFrame());
4653 return m_initialViewportSize.height(); 4653 return m_initialViewportSize.height();
4654 } 4654 }
4655 4655
4656 } // namespace blink 4656 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698