Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed ESTABLISHED/DISSOLVED Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1852 matching lines...) Expand 10 before | Expand all | Expand 10 after
1863 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1863 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1864 } 1864 }
1865 } 1865 }
1866 1866
1867 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1867 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1868 CompositedSelection& selection) { 1868 CompositedSelection& selection) {
1869 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1869 if (!frame.view() || frame.view()->shouldThrottleRendering())
1870 return false; 1870 return false;
1871 1871
1872 const VisibleSelection& visibleSelection = frame.selection().selection(); 1872 const VisibleSelection& visibleSelection = frame.selection().selection();
1873 if (visibleSelection.isNone()) 1873 if (visibleSelection.isNone() || !frame.selection().isHandleVisible())
1874 return false; 1874 return false;
1875 1875
1876 // Non-editable caret selections lack any kind of UI affordance, and 1876 // Non-editable caret selections lack any kind of UI affordance, and
1877 // needn't be tracked by the client. 1877 // needn't be tracked by the client.
1878 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1878 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1879 return false; 1879 return false;
1880 1880
1881 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1881 VisiblePosition visibleStart(visibleSelection.visibleStart());
1882 RenderedPosition renderedStart(visibleStart); 1882 RenderedPosition renderedStart(visibleStart);
1883 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1883 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 2701 matching lines...) Expand 10 before | Expand all | Expand 10 after
4585 DCHECK(m_frame->isMainFrame()); 4585 DCHECK(m_frame->isMainFrame());
4586 return m_initialViewportSize.width(); 4586 return m_initialViewportSize.width();
4587 } 4587 }
4588 4588
4589 int FrameView::initialViewportHeight() const { 4589 int FrameView::initialViewportHeight() const {
4590 DCHECK(m_frame->isMainFrame()); 4590 DCHECK(m_frame->isMainFrame());
4591 return m_initialViewportSize.height(); 4591 return m_initialViewportSize.height();
4592 } 4592 }
4593 4593
4594 } // namespace blink 4594 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698