Blink handle selection handle visibility

third_party/WebKit/Source/core/editing/FrameSelection.h

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 106 matching lines @@
               CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded);
   void moveTo(const Position&, TextAffinity);
 
   template <typename Strategy>
   const VisibleSelectionTemplate<Strategy>& visibleSelection() const;
 
   const VisibleSelection& selection() const;
   void setSelection(const VisibleSelection&,
                     SetSelectionOptions = CloseTyping | ClearTypingStyle,
                     CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
-                    TextGranularity = CharacterGranularity);
+                    TextGranularity = CharacterGranularity,
+                    bool isHandleVisible = false);

[yosin_UTC9, 2016/10/17 07:27:46]

Could you pass |isHandleVisible| in |SetSelectionOptions| rather than adding
additional |bool| parameter?
If so, patch size becomes smaller.
Note: Blink doesn't prefer |bool| parameter, if we really needed it should be
|enum class|.

[amaralp, 2016/10/19 04:26:38]

Done.

   void setSelection(const VisibleSelectionInFlatTree&,
                     SetSelectionOptions = CloseTyping | ClearTypingStyle,
                     CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
-                    TextGranularity = CharacterGranularity);
+                    TextGranularity = CharacterGranularity,
+                    bool isHandleVisible = false);
   // TODO(yosin) We should get rid of two parameters version of
   // |setSelection()| to avoid conflict of four parameters version.
   void setSelection(const VisibleSelection& selection,
-                    TextGranularity granularity) {
+                    TextGranularity granularity,
+                    bool isHandleVisible = false) {
     setSelection(selection, CloseTyping | ClearTypingStyle,
-                 CursorAlignOnScroll::IfNeeded, granularity);
+                 CursorAlignOnScroll::IfNeeded, granularity, isHandleVisible);
   }
   // TODO(yosin) We should get rid of |Range| version of |setSelectedRagne()|
   // for Oilpan.
   bool setSelectedRange(
       Range*,
       TextAffinity,
       SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional,
       SetSelectionOptions = CloseTyping | ClearTypingStyle);
   bool setSelectedRange(
       const EphemeralRange&,
       TextAffinity,
       SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional,
       FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle);
   void selectAll();
   void clear();
 
   // Call this after doing user-triggered selections to make it easy to delete
   // the frame you entirely selected.
   void selectFrameElementInParentIfFullySelected();
 
+  bool contains(const HitTestResult&);
   bool contains(const LayoutPoint&);
 
   SelectionType getSelectionType() const {
     return selection().getSelectionType();
   }
 
   TextAffinity affinity() const { return selection().affinity(); }
 
   bool modify(EAlteration,
               SelectionDirection,
@@ skipping 67 matching lines @@
   // Used to suspend caret blinking while the mouse is down.
   void setCaretBlinkingSuspended(bool);
   bool isCaretBlinkingSuspended() const;
 
   // Focus
   void setFocused(bool);
   bool isFocused() const { return m_focused; }
   bool isFocusedAndActive() const;
   void pageActivationChanged();
 
+  bool isHandleVisible() const { return m_isHandleVisible; }
+
   void updateSecureKeyboardEntryIfActive();
 
   // Returns true if a word is selected.
   bool selectWordAroundPosition(const VisiblePosition&);
 
 #ifndef NDEBUG
   void showTreeForThis() const;
 #endif
 
   enum EndPointsAdjustmentMode {
     AdjustEndpointsAtBidiBoundary,
-    DoNotAdjsutEndpoints
+    DoNotAdjustEndpoints

[yosin_UTC9, 2016/10/17 07:27:46]

Good catch!
http://crrev.com/2424703002 will fix this. Committing now...

[amaralp, 2016/10/19 04:26:38]

Thanks!

   };
   void setNonDirectionalSelectionIfNeeded(
       const VisibleSelectionInFlatTree&,
       TextGranularity,
-      EndPointsAdjustmentMode = DoNotAdjsutEndpoints);
+      EndPointsAdjustmentMode = DoNotAdjustEndpoints,
+      bool isHandleVisible = false);
   void setFocusedNodeIfNeeded();
   void notifyLayoutObjectOfSelectionChange(EUserTriggered);
 
   EditingStyle* typingStyle() const;
   void setTypingStyle(EditingStyle*);
   void clearTypingStyle();
 
   String selectedHTMLForClipboard() const;
   String selectedText(TextIteratorBehavior = TextIteratorDefaultBehavior) const;
   String selectedTextForClipboard() const;
@@ skipping 36 matching lines @@
 
   template <typename Strategy>
   VisiblePositionTemplate<Strategy> originalBase() const;
   void setOriginalBase(const VisiblePosition&);
   void setOriginalBase(const VisiblePositionInFlatTree&);
 
   template <typename Strategy>
   void setSelectionAlgorithm(const VisibleSelectionTemplate<Strategy>&,
                              SetSelectionOptions,
                              CursorAlignOnScroll,
-                             TextGranularity);
+                             TextGranularity,
+                             bool isHandleVisible = false);
 
   void respondToNodeModification(Node&,
                                  bool baseRemoved,
                                  bool extentRemoved,
                                  bool startRemoved,
                                  bool endRemoved);
 
   void notifyAccessibilityForSelectionChange();
   void notifyCompositorForSelectionChange();
   void notifyEventHandlerForSelectionChange();
@@ skipping 24 matching lines @@
 
   // Used to store base before the adjustment at bidi boundary
   VisiblePositionInFlatTree m_originalBaseInFlatTree;
   TextGranularity m_granularity;
   LayoutUnit m_xPosForVerticalArrowNavigation;
 
   Member<EditingStyle> m_typingStyle;
 
   bool m_focused : 1;
 
+  bool m_isHandleVisible : 1;
+
   // Controls text granularity used to adjust the selection's extent in
   // moveRangeSelectionExtent.
   std::unique_ptr<GranularityStrategy> m_granularityStrategy;
 
   const Member<FrameCaret> m_frameCaret;
 };
 
 inline EditingStyle* FrameSelection::typingStyle() const {
   return m_typingStyle.get();
 }
 
 inline void FrameSelection::clearTypingStyle() {
   m_typingStyle.clear();
 }
 
 inline void FrameSelection::setTypingStyle(EditingStyle* style) {
   m_typingStyle = style;
 }
 }  // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::FrameSelection&);
 void showTree(const blink::FrameSelection*);
 #endif
 
 #endif  // FrameSelection_h