Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2201853002: Blink handle selection handle visibility (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: try running even rebaseline tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 1736 matching lines...) Expand 10 before | Expand all | Expand 10 after
1747 layoutViewItem.layer()->setNeedsCompositingInputsUpdate(); 1747 layoutViewItem.layer()->setNeedsCompositingInputsUpdate();
1748 } 1748 }
1749 } 1749 }
1750 1750
1751 bool FrameView::computeCompositedSelection(LocalFrame& frame, 1751 bool FrameView::computeCompositedSelection(LocalFrame& frame,
1752 CompositedSelection& selection) { 1752 CompositedSelection& selection) {
1753 if (!frame.view() || frame.view()->shouldThrottleRendering()) 1753 if (!frame.view() || frame.view()->shouldThrottleRendering())
1754 return false; 1754 return false;
1755 1755
1756 const VisibleSelection& visibleSelection = frame.selection().selection(); 1756 const VisibleSelection& visibleSelection = frame.selection().selection();
1757 if (visibleSelection.isNone()) 1757 if (visibleSelection.isNone() || !visibleSelection.isHandleVisible())
1758 return false; 1758 return false;
1759 1759
1760 // Non-editable caret selections lack any kind of UI affordance, and 1760 // Non-editable caret selections lack any kind of UI affordance, and
1761 // needn't be tracked by the client. 1761 // needn't be tracked by the client.
1762 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable()) 1762 if (visibleSelection.isCaret() && !visibleSelection.isContentEditable())
1763 return false; 1763 return false;
1764 1764
1765 VisiblePosition visibleStart(visibleSelection.visibleStart()); 1765 VisiblePosition visibleStart(visibleSelection.visibleStart());
1766 RenderedPosition renderedStart(visibleStart); 1766 RenderedPosition renderedStart(visibleStart);
1767 renderedStart.positionInGraphicsLayerBacking(selection.start, true); 1767 renderedStart.positionInGraphicsLayerBacking(selection.start, true);
(...skipping 2802 matching lines...) Expand 10 before | Expand all | Expand 10 after
4570 } 4570 }
4571 4571
4572 bool FrameView::canThrottleRendering() const { 4572 bool FrameView::canThrottleRendering() const {
4573 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled()) 4573 if (!RuntimeEnabledFeatures::renderingPipelineThrottlingEnabled())
4574 return false; 4574 return false;
4575 return m_subtreeThrottled || 4575 return m_subtreeThrottled ||
4576 (m_hiddenForThrottling && m_crossOriginForThrottling); 4576 (m_hiddenForThrottling && m_crossOriginForThrottling);
4577 } 4577 }
4578 4578
4579 } // namespace blink 4579 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698