Blink handle selection handle visibility

content/browser/renderer_host/input/stylus_text_selector.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_INPUT_STYLUS_TEXT_SELECTOR_H_
 #define CONTENT_BROWSER_RENDERER_HOST_INPUT_STYLUS_TEXT_SELECTOR_H_
 
 #include <memory>
 
 #include "base/gtest_prod_util.h"
@@ skipping 13 matching lines @@
 // Interface with which the StylusTextSelector conveys drag and tap gestures
 // when the activating button is pressed.
 // selection handles, or long press.
 class CONTENT_EXPORT StylusTextSelectorClient {
  public:
   virtual ~StylusTextSelectorClient() {}
 
   // (x0, y0) and (x1, y1) indicate the bounds of the initial selection.
   virtual void OnStylusSelectBegin(float x0, float y0, float x1, float y1) = 0;
   virtual void OnStylusSelectUpdate(float x, float y) = 0;
-  virtual void OnStylusSelectEnd() = 0;

[aelias_OOO_until_Jul13, 2016/10/07 02:40:20]

Begin/End pairs are a common pattern and it's weird to only have the Begin, even
if right now the End is just logging.  I'd prefer this be kept.

[amaralp, 2016/10/14 00:53:07]

Done.

   virtual void OnStylusSelectTap(base::TimeTicks time, float x, float y) = 0;
 };
 
 // Provides stylus-based text selection and interaction, including:
 //   * Selection manipulation when an activating stylus button is pressed and
 //     the stylus is dragged.
 //   * Word selection and context menu activation when the when an activating
 //     stylus button is pressed and the stylus is tapped.
 class CONTENT_EXPORT StylusTextSelector : public ui::SimpleGestureListener {
  public:
@@ skipping 15 matching lines @@
                 const ui::MotionEvent& secondary_pointer_down,
                 float distance_x,
                 float distance_y) override;
 
   static bool ShouldStartTextSelection(const ui::MotionEvent& event);
 
   StylusTextSelectorClient* client_;
   bool text_selection_triggered_;
   bool secondary_button_pressed_;
   bool dragging_;
-  bool dragged_;

[aelias_OOO_until_Jul13, 2016/10/07 02:40:20]

Please move this cleanup to separate patch to keep this one a closure of related
changes.

[amaralp, 2016/10/14 00:53:07]

Done.

   float anchor_x_;
   float anchor_y_;
   std::unique_ptr<ui::GestureDetector> gesture_detector_;
 
   DISALLOW_COPY_AND_ASSIGN(StylusTextSelector);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_INPUT_STYLUS_TEXT_SELECTOR_H_