Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5518)

Unified Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2201833002: Added tombstones in instrumentation tests results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: indentation fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/local/device/local_device_instrumentation_test_run.py
diff --git a/build/android/pylib/local/device/local_device_instrumentation_test_run.py b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
index 26d10f4d1d7ed797a4682a0acae6ff13b382281e..c5e6a46c8d09410e5a6f9e2a7456c10e68bf74f9 100644
--- a/build/android/pylib/local/device/local_device_instrumentation_test_run.py
+++ b/build/android/pylib/local/device/local_device_instrumentation_test_run.py
@@ -6,6 +6,7 @@ import logging
import os
import posixpath
import re
+import sys
import time
from devil.android import device_errors
@@ -16,6 +17,10 @@ from pylib.base import base_test_result
from pylib.local.device import local_device_environment
from pylib.local.device import local_device_test_run
+from pylib.constants import host_paths
+sys.path.append(os.path.join(host_paths.DIR_SOURCE_ROOT, 'build', 'android'))
jbudorick 2016/08/04 23:54:18 This should already be in the path. In the event t
BigBossZhiling 2016/08/05 03:01:44 Done.
+import tombstones
+
TIMEOUT_ANNOTATIONS = [
('Manual', 10 * 60 * 60),
@@ -143,6 +148,8 @@ class LocalDeviceInstrumentationTestRun(
else:
for step in steps:
step()
+ if self._test_instance.store_tombstones:
+ tombstones.ClearAllTombstones(dev)
self._env.parallel_devices.pMap(
individual_device_set_up,
@@ -329,6 +336,15 @@ class LocalDeviceInstrumentationTestRun(
self._test_instance.coverage_directory)
device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,
'*'))
+ if self._test_instance.store_tombstones:
+ for result in results:
+ if result.GetType() == base_test_result.ResultType.FAIL:
+ tombstones.ResolveTombstones(
+ device,
+ resolve_all_tombstones=True,
+ include_stack_symbols=False,
+ wipe_tombstones=True)
+ result.SetTombstones(tombstones)
jbudorick 2016/08/04 23:54:18 You're passing the module here.
BigBossZhiling 2016/08/05 03:01:44 Done.
return results
#override

Powered by Google App Engine
This is Rietveld 408576698