Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Side by Side Diff: build/android/pylib/local/device/local_device_instrumentation_test_run.py

Issue 2201833002: Added tombstones in instrumentation tests results. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import logging 5 import logging
6 import os 6 import os
7 import posixpath 7 import posixpath
8 import re 8 import re
9 import sys
9 import time 10 import time
10 11
11 from devil.android import device_errors 12 from devil.android import device_errors
12 from devil.android import flag_changer 13 from devil.android import flag_changer
13 from devil.utils import reraiser_thread 14 from devil.utils import reraiser_thread
14 from pylib import valgrind_tools 15 from pylib import valgrind_tools
15 from pylib.base import base_test_result 16 from pylib.base import base_test_result
16 from pylib.local.device import local_device_environment 17 from pylib.local.device import local_device_environment
17 from pylib.local.device import local_device_test_run 18 from pylib.local.device import local_device_test_run
18 19
20 sys.path.append(os.path.join('..', '..', '..'))
mikecase (-- gone --) 2016/08/01 22:44:30 I dont think you want to add ../../.. to the syste
BigBossZhiling 2016/08/01 23:04:35 Do you mean I should get the absolute path here? A
mikecase (-- gone --) 2016/08/02 00:48:30 This doesnt work I dont think. Im 80% sure this pa
21 import tombstones
22
19 23
20 TIMEOUT_ANNOTATIONS = [ 24 TIMEOUT_ANNOTATIONS = [
21 ('Manual', 10 * 60 * 60), 25 ('Manual', 10 * 60 * 60),
22 ('IntegrationTest', 30 * 60), 26 ('IntegrationTest', 30 * 60),
23 ('External', 10 * 60), 27 ('External', 10 * 60),
24 ('EnormousTest', 10 * 60), 28 ('EnormousTest', 10 * 60),
25 ('LargeTest', 5 * 60), 29 ('LargeTest', 5 * 60),
26 ('MediumTest', 3 * 60), 30 ('MediumTest', 3 * 60),
27 ('SmallTest', 1 * 60), 31 ('SmallTest', 1 * 60),
28 ] 32 ]
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
136 140
137 valgrind_tools.SetChromeTimeoutScale( 141 valgrind_tools.SetChromeTimeoutScale(
138 dev, self._test_instance.timeout_scale) 142 dev, self._test_instance.timeout_scale)
139 143
140 steps = (install_apk, push_test_data, create_flag_changer) 144 steps = (install_apk, push_test_data, create_flag_changer)
141 if self._env.concurrent_adb: 145 if self._env.concurrent_adb:
142 reraiser_thread.RunAsync(steps) 146 reraiser_thread.RunAsync(steps)
143 else: 147 else:
144 for step in steps: 148 for step in steps:
145 step() 149 step()
150 if self._test_instance.store_tombstones:
151 tombstones.ClearAllTombstones(dev)
146 152
147 self._env.parallel_devices.pMap( 153 self._env.parallel_devices.pMap(
148 individual_device_set_up, 154 individual_device_set_up,
149 self._test_instance.GetDataDependencies()) 155 self._test_instance.GetDataDependencies())
150 156
151 def TearDown(self): 157 def TearDown(self):
152 @local_device_environment.handle_shard_failures_with( 158 @local_device_environment.handle_shard_failures_with(
153 self._env.BlacklistDevice) 159 self._env.BlacklistDevice)
154 def individual_device_tear_down(dev): 160 def individual_device_tear_down(dev):
155 if str(dev) in self._flag_changers: 161 if str(dev) in self._flag_changers:
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 328
323 else: 329 else:
324 logging.debug('raw output from %s:', test_display_name) 330 logging.debug('raw output from %s:', test_display_name)
325 for l in output: 331 for l in output:
326 logging.debug(' %s', l) 332 logging.debug(' %s', l)
327 if self._test_instance.coverage_directory: 333 if self._test_instance.coverage_directory:
328 device.PullFile(coverage_directory, 334 device.PullFile(coverage_directory,
329 self._test_instance.coverage_directory) 335 self._test_instance.coverage_directory)
330 device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory, 336 device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,
331 '*')) 337 '*'))
338 if self._test_instance.store_tombstones:
339 for result in results:
340 if result.GetType() == base_test_result.ResultType.FAIL:
341 tombstones.ResolveAllTombstones(device, True, False, True)
342 result.set_tombstones(tombstones)
332 return results 343 return results
333 344
334 #override 345 #override
335 def _ShouldRetry(self, test): 346 def _ShouldRetry(self, test):
336 if 'RetryOnFailure' in test.get('annotations', {}): 347 if 'RetryOnFailure' in test.get('annotations', {}):
337 return True 348 return True
338 349
339 # TODO(jbudorick): Remove this log message and switch the return value to 350 # TODO(jbudorick): Remove this log message and switch the return value to
340 # False after tests have been annotated with @RetryOnFailure. 351 # False after tests have been annotated with @RetryOnFailure.
341 # See crbug.com/619055 for more details. 352 # See crbug.com/619055 for more details.
(...skipping 19 matching lines...) Expand all
361 timeout = v 372 timeout = v
362 break 373 break
363 else: 374 else:
364 logging.warning('Using default 1 minute timeout for %s', test_name) 375 logging.warning('Using default 1 minute timeout for %s', test_name)
365 timeout = 60 376 timeout = 60
366 377
367 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations) 378 timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
368 379
369 return timeout 380 return timeout
370 381
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698