Added tombstones in instrumentation tests results.

build/android/pylib/local/device/local_device_instrumentation_test_run.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import posixpath
 import re
+import sys
 import time
 
 from devil.android import device_errors
 from devil.android import flag_changer
 from devil.utils import reraiser_thread
 from pylib import valgrind_tools
 from pylib.base import base_test_result
 from pylib.local.device import local_device_environment
 from pylib.local.device import local_device_test_run
 
+from pylib.constants import host_paths
+sys.path.append(os.path.join(host_paths.DIR_SOURCE_ROOT, 'build', 'android'))
+import tombstones
+
 
 TIMEOUT_ANNOTATIONS = [
   ('Manual', 10 * 60 * 60),
   ('IntegrationTest', 30 * 60),
   ('External', 10 * 60),
   ('EnormousTest', 10 * 60),
   ('LargeTest', 5 * 60),
   ('MediumTest', 3 * 60),
   ('SmallTest', 1 * 60),
 ]
@@ skipping 107 matching lines @@
 
         valgrind_tools.SetChromeTimeoutScale(
             dev, self._test_instance.timeout_scale)
 
       steps = (install_apk, push_test_data, create_flag_changer)
       if self._env.concurrent_adb:
         reraiser_thread.RunAsync(steps)
       else:
         for step in steps:
           step()
+      if self._test_instance.store_tombstones:
+        tombstones.ClearAllTombstones(dev)

[mikecase (-- gone --), 2016/08/04 01:12:05]

There is a recipe step on our infrastructure that collects all the tombstones at
the end of the test runs and lists them out. Will this break that script? I
suppose as long as store_tombstones defaults to False to begin that shouldnt be
a problem.

[BigBossZhiling, 2016/08/04 23:20:28]

Acknowledged.

 
     self._env.parallel_devices.pMap(
         individual_device_set_up,
         self._test_instance.GetDataDependencies())
 
   def TearDown(self):
     @local_device_environment.handle_shard_failures_with(
         self._env.BlacklistDevice)
     def individual_device_tear_down(dev):
       if str(dev) in self._flag_changers:
@@ skipping 166 matching lines @@
 
     else:
       logging.debug('raw output from %s:', test_display_name)
       for l in output:
         logging.debug('  %s', l)
     if self._test_instance.coverage_directory:
       device.PullFile(coverage_directory,
           self._test_instance.coverage_directory)
       device.RunShellCommand('rm -f %s' % os.path.join(coverage_directory,
           '*'))
+    if self._test_instance.store_tombstones:
+      for result in results:
+        if result.GetType() == base_test_result.ResultType.FAIL:
+          tombstones.ResolveTombstones(
+            device,

[mikecase (-- gone --), 2016/08/04 01:12:05]

nit: wrong indent. Need 4 spaces.

[BigBossZhiling, 2016/08/04 23:20:28]

Done.

+            resolve_all_tombstones=True,
+            include_stack_symbols=False,
+            wipe_tombstones=True)
+          result.SetTombstones(tombstones)

[mikecase (-- gone --), 2016/08/04 01:12:05]

So, Im not too sure what tombstones really are to be honest. Do you know if they
are generated by the death tests? 

[BigBossZhiling, 2016/08/04 23:20:28]

What are death tests? I think if a test crashes, then a tombstone will be
created. Passing and Failing testcases do not usually create tombstones. I also
sent out an email containing a sample tombstone.

     return results
 
   #override
   def _ShouldRetry(self, test):
     if 'RetryOnFailure' in test.get('annotations', {}):
       return True
 
     # TODO(jbudorick): Remove this log message and switch the return value to
     # False after tests have been annotated with @RetryOnFailure.
     # See crbug.com/619055 for more details.
@@ skipping 19 matching lines @@
         timeout = v
         break
     else:
       logging.warning('Using default 1 minute timeout for %s', test_name)
       timeout = 60
 
     timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
 
     return timeout