Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 2201803002: Mark native methods as external. (Closed)

Created:
4 years, 4 months ago by ahe
Modified:
4 years, 4 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com, Vyacheslav Egorov (Google), kustermann
Base URL:
git@github.com:dart-lang/rasta.git@dill
Target Ref:
refs/heads/master
Project:
Rasta
Visibility:
Public.

Description

Mark native methods as external. This ports ab71d8b5a96f856842ca8290ab5694cccfba548d to master. R=kasperl@google.com Committed: https://github.com/dart-lang/rasta/commit/173967fd0bd33e4a4907bb4021530191a9cb6e7d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -9 lines) Patch
M lib/custom_backend.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M lib/custom_compiler_options.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/kernel.dart View 3 chunks +22 lines, -2 lines 0 comments Download
A + test/kernel/regression/native/native_is_external.dart View 1 chunk +6 lines, -3 lines 0 comments Download
A test/kernel/regression/native/native_is_external.dart.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A + test/kernel/regression/native_is_illegal.dart View 1 chunk +6 lines, -3 lines 0 comments Download
A test/kernel/regression/native_is_illegal.dart.txt View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
ahe
4 years, 4 months ago (2016-08-02 14:04:03 UTC) #5
kasperl
LGTM.
4 years, 4 months ago (2016-08-03 05:16:07 UTC) #6
ahe
4 years, 4 months ago (2016-08-03 09:01:57 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:40001) manually as
173967fd0bd33e4a4907bb4021530191a9cb6e7d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698