android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java - Issue 2201783003: Add test to ensure shouldOverrideUrlLoading throws Java exception

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

Issue 2201783003: Add test to ensure shouldOverrideUrlLoading throws Java exception (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add testbase for separate-service tests, use this from AwSecondBrowserTest. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AndroidViewIntegrationTest.java ('k') | android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java » ('j') | android_webview/javatests/src/org/chromium/android_webview/test/AwSecondBrowserProcessTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

index f3bfa7f4102e1f72c5b81a75bf7e177c16f0ff22..84e6e496d67bbe4d5c9b59291018850d91301f1c 100644

--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsGarbageCollectionTest.java

@@ -14,6 +14,7 @@ import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.android_webview.AwContents;

import org.chromium.android_webview.AwGLFunctor;

+import org.chromium.android_webview.test.AwTestBaseUtility.TestDependencyFactory;

import org.chromium.base.annotations.SuppressFBWarnings;

import org.chromium.base.test.util.Feature;

import org.chromium.content.browser.test.util.Criteria;

@@ -70,8 +71,8 @@ public class AwContentsGarbageCollectionTest extends AwTestBase {

@Override

public AwTestContainerView createAwTestContainerView(

- AwTestRunnerActivity activity, boolean allowHardwareAcceleration) {

- if (activity != mContext.getBaseContext()) fail();

+ Context context, boolean allowHardwareAcceleration) {

+ if (context != mContext.getBaseContext()) fail();

return new AwTestContainerView(mContext, allowHardwareAcceleration);

}