Add test to ensure shouldOverrideUrlLoading throws Java exception

android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java

Index: android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
diff --git a/android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java b/android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
index eaf350f0e27be369a85266dae06368fb5e1fdcfc..dd3272ce2896a2a4605ebe3803c55388fd8865bc 100644
--- a/android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
+++ b/android_webview/test/shell/src/org/chromium/android_webview/test/SecondBrowserProcess.java
@@ -5,6 +5,7 @@
 package org.chromium.android_webview.test;
 
 import android.app.Service;
+import android.content.Context;
 import android.content.Intent;
 import android.os.Binder;
 import android.os.IBinder;
@@ -31,7 +32,7 @@ public class SecondBrowserProcess extends Service {
                 case CODE_START:
                     reply.writeNoException();
                     try {
-                        startBrowserProcess();
+                        startBrowserProcess(SecondBrowserProcess.this);
                         reply.writeInt(Process.myPid());
                     } catch (Exception e) {
                         reply.writeInt(0);
@@ -53,11 +54,11 @@ public class SecondBrowserProcess extends Service {
     }
 
     @SuppressFBWarnings("DMI_HARDCODED_ABSOLUTE_FILENAME")
-    private void startBrowserProcess() throws Exception {
+    static void startBrowserProcess(Context context) throws Exception {

[boliu, 2016/08/02 20:15:59]

uhh, move this somewhere that appears more "shared", another file?

actually, one service per test sucks, can we re-use the same service (give it a
more generic name), and just work out what to do depending on what message is
received?

[gsennton, 2016/08/02 20:33:57]

Sure, will do :)

[gsennton, 2016/09/06 15:26:08]

Actually, IMO we shouldn't merge these services because SecondBrowserProcess is
simpler than SeparateProcessWebViewService - the latter needs to communicate
with the corresponding test long after the initial setup-communication is done
(i.e. the communication needs to happen in the uncaughtExceptionHandler) while
SecondBrowserProcess can just run the code it wants to test and then return the
result directly. So to communicate in the new Service I'm using Messengers while
SecondBrowserProcess just uses the onTransact method.
SecondBrowserProcess is easier to read/interpret as is IMO (actually, the
primary reason I don't want to merge the services is because then I would have
to re-run/fix the tests that use SecondBrowserProcess to ensure they work
correctly).

Does this make sense? (merging them shouldn't be too difficult, it just seems
like extra work for very little gain). If we don't merge them I'll move the
startBrowserProcess method somewhere else.

[boliu, 2016/09/07 18:32:40]

Always optimize for code that's easy to understand rather than code that's easy
to write. Code is read a lot more often than it's written.

I'll leave the decision to you, but sounds like this case, SecondBrowserProcess
can be easily rewritten on top of Messenger. But having two tests living in the
same file might look messy and confusing too. Maybe something that sets up the
service, which calls out to test bodies in separate files. It's like you are
writing junit on top of android services.

[gsennton, 2016/09/14 13:51:51]

Yes, this - having a general-purpose Service as base and building tests in
separate files on top - sounds like the best solution :) (this solution should
make it easy to add new similar tests in the future). PS5 implements this.

It would be even better if we could put the "junit on top of android services"
classes in the test apk and keep the service in the shell apk - in that way all
the testing functionality could still remain in the test apk (though I can't
think of decent way of implementing this in such a way - since the Service
itself lives in the shell apk and needs access to the class where we put our
code).

         CommandLine.initFromFile("/data/local/tmp/android-webview-command-line");
-        AwResource.setResources(this.getResources());
+        AwResource.setResources(context.getResources());
         AwResource.setConfigKeySystemUuidMapping(R.array.config_key_system_uuid_mapping);
-        ContextUtils.initApplicationContext(getApplicationContext());
+        ContextUtils.initApplicationContext(context.getApplicationContext());
         AwBrowserProcess.loadLibrary();
         AwBrowserProcess.start();
     }