Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2201783002: Remove grammar marker inspection from WebFrameTest (Closed)

Created:
4 years, 4 months ago by Xiaocheng
Modified:
4 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove grammar marker inspection from WebFrameTest This patch is part of the refactoring of removing grammar checking code, because neither Chromium nor Blink supports supports grammar checking. BUG=619452 TEST=n/a; this patch changes a test file Committed: https://crrev.com/ca4b6d233d131487b752e5c92ff16f56779b3f7a Cr-Commit-Position: refs/heads/master@{#409115}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 3 chunks +1 line, -15 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Xiaocheng
PTAL.
4 years, 4 months ago (2016-08-01 15:11:44 UTC) #6
tkent
lgtm. Please write why we remove it in the CL description.
4 years, 4 months ago (2016-08-01 22:44:09 UTC) #7
Xiaocheng
Thanks for the review.
4 years, 4 months ago (2016-08-02 01:28:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201783002/1
4 years, 4 months ago (2016-08-02 01:28:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 01:32:09 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 01:33:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca4b6d233d131487b752e5c92ff16f56779b3f7a
Cr-Commit-Position: refs/heads/master@{#409115}

Powered by Google App Engine
This is Rietveld 408576698