Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 2201703002: SELECT popup: Tentative fix for an issue on Android WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index aa894aeee83a09ce6d791669d9c477ef31d8b2ac..271a9d84cedf1ffc61b0d23912f1481b92152030 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -1919,8 +1919,12 @@ void HTMLSelectElement::showPopup()
return;
if (!layoutObject() || !layoutObject()->isMenuList())
return;
+ // Disable visibility check on Android. elementRectRelativeToViewport()
+ // doesn't work well on Android WebView. crbug.com/632561
+#if !OS(ANDROID)
if (elementRectRelativeToViewport().isEmpty())
return;
+#endif
if (!m_popup)
m_popup = document().frameHost()->chromeClient().openPopupMenu(*document().frame(), *this);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698