Issue 2201703002: SELECT popup: Tentative fix for an issue on Android WebView.

Issue 2201703002: SELECT popup: Tentative fix for an issue on Android WebView. (Closed)

Created:
4 years, 4 months ago by tkent

Modified:
4 years, 4 months ago

Reviewers:
keishi

CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

SELECT popup: Tentative fix for an issue on Android WebView. Disable element visibility check only on Android. BUG=632561 Committed: https://crrev.com/ae36669618d5cb79d22efee333034ed719066f9d Cr-Commit-Position: refs/heads/master@{#408903}

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/html/HTMLSelectElement.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Total messages: 11 (6 generated)

tkent

Keishi, would you review this asap please? It seems widget rect in WebView isn't compatible ...

4 years, 4 months ago (2016-08-01 03:03:42 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201703002/1

4 years, 4 months ago (2016-08-01 03:07:53 UTC) #8

commit-bot: I haz the power

4 years, 4 months ago (2016-08-01 03:13:41 UTC) #11

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ae36669618d5cb79d22efee333034ed719066f9d
Cr-Commit-Position: refs/heads/master@{#408903}