Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2201663002: Change typ's interpretation of a test that first fails and is then skipped. (Closed)

Created:
4 years, 4 months ago by Dirk Pranke
Modified:
4 years, 3 months ago
Reviewers:
nednguyen
Base URL:
https://github.com/dpranke/typ.git@master
Target Ref:
refs/heads/master
Project:
typ
Visibility:
Public.

Description

Change typ's interpretation of a test that first fails and is then skipped. Previously, if a test failed and typ retried it, but for whatever reason the test was skipped on subsequent retries, the test was considered to have failed (since it never passed) and so the whole test run failed. This is perhaps inconsistent with how typ would've reacted if the test was skipped *every* time, and so arguably this is the wrong thing to do. For now, I'm changing the behavior so that subsequent skips are treated like subsequent passes (i.e., the test didn't fail every time). If you really want different behavior you can look at the full list of results yourself. Also, bump the typ version to 0.9.6, and add a codereview.settings flag so that I can use Rietveld. R=nednguyen@google.com BUG=618330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download
M typ/json_results.py View 3 chunks +12 lines, -5 lines 0 comments Download
M typ/tests/main_test.py View 2 chunks +27 lines, -1 line 0 comments Download
M typ/version.py View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 6 (2 generated)
Dirk Pranke
4 years, 4 months ago (2016-07-31 23:00:01 UTC) #3
nednguyen
lgtm
4 years, 4 months ago (2016-08-02 21:13:50 UTC) #4
rnephew (Reviews Here)
On 2016/08/02 21:13:50, nednguyen wrote: > lgtm Any update on landing this? It would be ...
4 years, 4 months ago (2016-08-22 20:55:41 UTC) #5
Dirk Pranke
4 years, 4 months ago (2016-08-22 23:14:15 UTC) #6
On 2016/08/22 20:55:41, rnephew (Reviews Here) wrote:
> On 2016/08/02 21:13:50, nednguyen wrote:
> > lgtm
> 
> Any update on landing this? It would be nice to unblacklist the battor tests
for
> smoke tests. (Done in CL below).
> 
> https://codereview.chromium.org/2187183002/

Sorry, I thought you were still trying to fix the other issue.

I can land this in the next day or two.

Powered by Google App Engine
This is Rietveld 408576698