Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: extensions/common/features/complex_feature.h

Issue 2201653003: Revert of Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/complex_feature.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/complex_feature.h
diff --git a/extensions/common/features/complex_feature.h b/extensions/common/features/complex_feature.h
index 9ccbd4fec4aecffe3ac5774bae84f3d7a00ac00f..7b63ae6f957b08809537c9ac8891ddc51dc9db66 100644
--- a/extensions/common/features/complex_feature.h
+++ b/extensions/common/features/complex_feature.h
@@ -23,8 +23,9 @@
// available, but not if only some combination of Features is available.
class ComplexFeature : public Feature {
public:
- // Takes ownership of Feature*s contained in |features|.
- explicit ComplexFeature(std::vector<Feature*>* features);
+ using FeatureList = std::vector<std::unique_ptr<Feature>>;
+
+ explicit ComplexFeature(std::unique_ptr<FeatureList> features);
~ComplexFeature() override;
// extensions::Feature:
@@ -49,7 +50,6 @@
private:
FRIEND_TEST_ALL_PREFIXES(FeaturesGenerationTest, FeaturesTest);
- using FeatureList = std::vector<std::unique_ptr<Feature>>;
FeatureList features_;
DISALLOW_COPY_AND_ASSIGN(ComplexFeature);
« no previous file with comments | « extensions/common/features/base_feature_provider.cc ('k') | extensions/common/features/complex_feature.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698