Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: extensions/common/features/simple_feature_unittest.cc

Issue 2201653003: Revert of Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/features/json_feature_provider.cc ('k') | tools/json_schema_compiler/feature_compiler.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/features/simple_feature_unittest.cc
diff --git a/extensions/common/features/simple_feature_unittest.cc b/extensions/common/features/simple_feature_unittest.cc
index 5ad4f78b466bde4cff4d59b4b7cc3e72a1fd2027..2f40b81083befc0f0c6353259130194f1fa5b1da 100644
--- a/extensions/common/features/simple_feature_unittest.cc
+++ b/extensions/common/features/simple_feature_unittest.cc
@@ -881,10 +881,11 @@
feature2->channel_.reset(
new version_info::Channel(version_info::Channel::BETA));
feature2->extension_types_.push_back(Manifest::TYPE_LEGACY_PACKAGED_APP);
- std::vector<Feature*> list;
- list.push_back(feature1.release());
- list.push_back(feature2.release());
- complex_feature.reset(new ComplexFeature(&list));
+ std::unique_ptr<ComplexFeature::FeatureList> list(
+ new ComplexFeature::FeatureList());
+ list->push_back(std::move(feature1));
+ list->push_back(std::move(feature2));
+ complex_feature.reset(new ComplexFeature(std::move(list)));
}
Feature* feature = static_cast<Feature*>(complex_feature.get());
@@ -935,10 +936,11 @@
feature2->channel_.reset(
new version_info::Channel(version_info::Channel::STABLE));
feature2->extension_types_.push_back(Manifest::TYPE_LEGACY_PACKAGED_APP);
- std::vector<Feature*> list;
- list.push_back(feature1.release());
- list.push_back(feature2.release());
- complex_feature.reset(new ComplexFeature(&list));
+ std::unique_ptr<ComplexFeature::FeatureList> list(
+ new ComplexFeature::FeatureList());
+ list->push_back(std::move(feature1));
+ list->push_back(std::move(feature2));
+ complex_feature.reset(new ComplexFeature(std::move(list)));
}
Feature* feature = static_cast<Feature*>(complex_feature.get());
« no previous file with comments | « extensions/common/features/json_feature_provider.cc ('k') | tools/json_schema_compiler/feature_compiler.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698