extensions/common/features/base_feature_provider.h - Issue 2201653003: Revert of Further reduction of feature_compiler.py generated code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/features/base_feature_provider.h

Issue 2201653003: Revert of Further reduction of feature_compiler.py generated code (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@test-with-leiz

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/common/features/base_feature_provider.h

diff --git a/extensions/common/features/base_feature_provider.h b/extensions/common/features/base_feature_provider.h

index 1b840f393ca6141c3554b729e640cb2c2c43cfa9..5b6be3d3ce76d79a7673fd467e76f878a1a13d74 100644

--- a/extensions/common/features/base_feature_provider.h

+++ b/extensions/common/features/base_feature_provider.h

@@ -41,10 +41,6 @@

void AddFeature(base::StringPiece name, std::unique_ptr<Feature> feature);

- // Takes ownership. Used in preference to unique_ptr variant to reduce size

- // of generated code.

- void AddFeature(base::StringPiece name, Feature* feature);

private:

std::map<std::string, std::unique_ptr<Feature>> features_;

« no previous file with comments | « no previous file | extensions/common/features/base_feature_provider.cc » ('j') | no next file with comments »