Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2201653002: Remove usage of wildcard imports from webkitpy. (Closed)

Created:
4 years, 4 months ago by qyearsley
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of wildcard imports from webkitpy. This fixes all of the "unused-wildcard-import" pylint warnings, which were recently enabled in http://crrev.com/2120083002. The rationale for enabling this warning is that wildcard imports can make it less clear where all of the imported names come from. Explicitly listing all names to import makes it a bit clearer. BUG=598897 Committed: https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f Cr-Commit-Position: refs/heads/master@{#410728}

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Rebased #

Patch Set 4 : Rebased; reformatted multiple imports from same module to be single import statements. #

Messages

Total messages: 11 (6 generated)
qyearsley
4 years, 4 months ago (2016-08-02 16:20:19 UTC) #2
Dirk Pranke
lgtm, though in many cases I would've used multiple classes on one line, e.g.: from ...
4 years, 4 months ago (2016-08-09 00:33:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2201653002/60001
4 years, 4 months ago (2016-08-09 16:32:55 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-09 17:35:04 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-09 17:37:08 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/46515a0de0eae9c36d27ec55ed41d7b07dee335f
Cr-Commit-Position: refs/heads/master@{#410728}

Powered by Google App Engine
This is Rietveld 408576698