Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4804)

Unified Diff: chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm

Issue 220163007: implement account removal card and add title to signin card on mac (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests fixed Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm b/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm
index 5490bb216c71f4a23e511206cbb0561f305f31f5..769f47e30ff9cac70abbea3969878a5ad11303b0 100644
--- a/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm
@@ -68,7 +68,7 @@ class ProfileChooserControllerTest : public CocoaProfileTest {
controller_.reset([[ProfileChooserController alloc]
initWithBrowser:browser()
anchoredAt:point
- withMode:PROFILE_CHOOSER_VIEW]);
+ withMode:BUBBLE_VIEW_MODE_PROFILE_CHOOSER]);
[controller_ showWindow:nil];
}
@@ -248,7 +248,7 @@ TEST_F(ProfileChooserControllerTest, AccountManagementLayout) {
UpdateCredentials(kSecondaryEmail, kLoginToken);
StartProfileChooserController();
- [controller() initMenuContentsWithView:ACCOUNT_MANAGEMENT_VIEW];
+ [controller() initMenuContentsWithView:BUBBLE_VIEW_MODE_ACCOUNT_MANAGEMENT];
NSArray* subviews = [[[controller() window] contentView] subviews];
@@ -286,14 +286,14 @@ TEST_F(ProfileChooserControllerTest, AccountManagementLayout) {
NSButton* genericAccount =
static_cast<NSButton*>([accountsListSubviews objectAtIndex:0]);
- EXPECT_EQ(@selector(removeAccount:), [genericAccount action]);
+ EXPECT_EQ(@selector(showAccountRemovalView:), [genericAccount action]);
EXPECT_EQ(controller(), [genericAccount target]);
- // Primary accounts are always last and can't be deleted.
+ // Primary accounts are always last.
NSButton* primaryAccount =
static_cast<NSButton*>([accountsListSubviews objectAtIndex:1]);
- EXPECT_EQ(nil, [primaryAccount action]);
- EXPECT_EQ(nil, [primaryAccount target]);
+ EXPECT_EQ(@selector(showAccountRemovalView:), [primaryAccount action]);
+ EXPECT_EQ(controller(), [primaryAccount target]);
// There should be another separator.
EXPECT_TRUE([[subviews objectAtIndex:3] isKindOfClass:[NSBox class]]);
« no previous file with comments | « chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698