Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: Source/core/rendering/compositing/CompositedLayerMapping.cpp

Issue 220163006: Begin simplifying CompositedLayerMapping::updateAfterLayout (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/compositing/CompositedLayerMapping.cpp
diff --git a/Source/core/rendering/compositing/CompositedLayerMapping.cpp b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
index e4abe10ba4f96f38ed918ccd333fceba0a99f49a..28c983f60ed0b47d9b3742790cb12b2195e942e0 100644
--- a/Source/core/rendering/compositing/CompositedLayerMapping.cpp
+++ b/Source/core/rendering/compositing/CompositedLayerMapping.cpp
@@ -428,7 +428,7 @@ void CompositedLayerMapping::updateCompositingReasons()
m_graphicsLayer->setCompositingReasons(m_owningLayer.compositingReasons());
}
-void CompositedLayerMapping::updateAfterLayout(UpdateAfterLayoutFlags flags)
+void CompositedLayerMapping::updateAfterLayout(bool needsFullRepaint, bool isUpdateRoot)
{
RenderLayerCompositor* layerCompositor = compositor();
if (!layerCompositor->compositingLayersNeedRebuild()) {
@@ -440,18 +440,18 @@ void CompositedLayerMapping::updateAfterLayout(UpdateAfterLayoutFlags flags)
// The solution is to update compositing children of this layer here,
// via updateCompositingChildrenGeometry().
updateCompositedBounds(GraphicsLayerUpdater::ForceUpdate);
- layerCompositor->updateCompositingDescendantGeometry(m_owningLayer.stackingNode(), &m_owningLayer, flags & CompositingChildrenOnly);
+ layerCompositor->updateCompositingDescendantGeometry(m_owningLayer.stackingNode(), &m_owningLayer);
- if (flags & IsUpdateRoot) {
+ if (isUpdateRoot) {
updateGraphicsLayerGeometry(GraphicsLayerUpdater::ForceUpdate);
layerCompositor->updateRootLayerPosition();
RenderLayerStackingNode* stackingContainer = m_owningLayer.stackingNode()->enclosingStackingContainerNode();
if (!layerCompositor->compositingLayersNeedRebuild() && stackingContainer && (stackingContainer != m_owningLayer.stackingNode()))
- layerCompositor->updateCompositingDescendantGeometry(stackingContainer, stackingContainer->layer(), flags & CompositingChildrenOnly);
+ layerCompositor->updateCompositingDescendantGeometry(stackingContainer, stackingContainer->layer());
}
}
- if (flags & NeedsFullRepaint && !paintsIntoCompositedAncestor())
+ if (needsFullRepaint && !paintsIntoCompositedAncestor())
setContentsNeedDisplay();
}

Powered by Google App Engine
This is Rietveld 408576698