[MD settings] only add overscroll if needed.

[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG=631332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4570d5e8b6094ee45234dcf1ef12f984dcd55d6f
Cr-Commit-Position: refs/heads/master@{#408847}

[dschuyler, 2016-07-30 00:43:03]

Description was changed from

==========
[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG=631332
==========

to

==========
[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG=631332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dschuyler, 2016-07-30 00:43:05]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 00:43:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-07-30 00:46:29]

dschuyler@chromium.org changed reviewers:
+ dbeam@chromium.org

[dschuyler, 2016-07-30 00:46:29]

https://codereview.chromium.org/2201553002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2201553002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_main/settings_main.js:145:
Polymer.dom.flush();
I moved this to keep all the timeout/flush
('is the dom ready to use?') code together.

[commit-bot: I haz the power, 2016-07-30 00:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:54:04]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[dschuyler, 2016-07-30 00:59:40]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 01:00:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Dan Beam, 2016-07-30 01:16:20]

https://codereview.chromium.org/2201553002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2201553002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:176:
(topSection.offsetParent.offsetTop + topSection.offsetTop)));
can you use some temporary variables so this statement is easier to understand?

[dschuyler, 2016-07-30 01:39:05]

The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 01:39:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dschuyler, 2016-07-30 01:39:45]

https://codereview.chromium.org/2201553002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/settings_main/settings_main.js (right):

https://codereview.chromium.org/2201553002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/settings_main/settings_main.js:176:
(topSection.offsetParent.offsetTop + topSection.offsetTop)));
On 2016/07/30 01:16:20, Dan Beam wrote:
> can you use some temporary variables so this statement is easier to
understand?

Done.

[Dan Beam, 2016-07-30 01:42:21]

lgtm

/cc michaelpg@

[commit-bot: I haz the power, 2016-07-30 02:40:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 02:40:02]

Dry run: This issue passed the CQ dry run.

[dschuyler, 2016-07-30 02:41:48]

The CQ bit was checked by dschuyler@chromium.org

[commit-bot: I haz the power, 2016-07-30 02:42:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 02:44:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-30 02:46:14]

Description was changed from

==========
[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG=631332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD settings] only add overscroll if needed.

This CL changes the overscroll padding so that it will be empty (zero
height) if no overscroll is needed to bring the selection to the top of
the window.

This Cl does not fix the overscroll during window resizing or hide the
overscroll when scrolling up. Those will be in a future CL.

BUG=631332
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/4570d5e8b6094ee45234dcf1ef12f984dcd55d6f
Cr-Commit-Position: refs/heads/master@{#408847}
==========

[commit-bot: I haz the power, 2016-07-30 02:46:15]

Patchset 3 (id:??) landed as
https://crrev.com/4570d5e8b6094ee45234dcf1ef12f984dcd55d6f
Cr-Commit-Position: refs/heads/master@{#408847}