Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7471)

Unified Diff: chrome/browser/printing/print_preview_dialog_controller.cc

Issue 2201543002: Fix print preview close in gmail. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moved logic for initiator nav after dialog nav Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_preview_dialog_controller.cc
diff --git a/chrome/browser/printing/print_preview_dialog_controller.cc b/chrome/browser/printing/print_preview_dialog_controller.cc
index 35635e61855c9432880f8c7a5f695ef1024f7361..7aa4b42ba3498729ec1d31d45c34e5461725f951 100644
--- a/chrome/browser/printing/print_preview_dialog_controller.cc
+++ b/chrome/browser/printing/print_preview_dialog_controller.cc
@@ -347,6 +347,14 @@ void PrintPreviewDialogController::OnNavEntryCommitted(
NOTREACHED();
return;
}
+ if (details) {
+ ui::PageTransition type = details->entry->GetTransitionType();
+ content::NavigationType nav_type = details->type;
+ if (nav_type == content::NAVIGATION_TYPE_EXISTING_PAGE &&
+ (ui::PageTransitionCoreTypeIs(type, ui::PAGE_TRANSITION_TYPED) ||
+ ui::PageTransitionCoreTypeIs(type, ui::PAGE_TRANSITION_LINK)))
+ return;
+ }
RemoveInitiator(contents);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698