Fix print preview close in gmail.

Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG=614998
Committed: https://crrev.com/85092cd8d7f4576aabaf2b9de9064978319c7388
Cr-Commit-Position: refs/heads/master@{#408860}

[rbpotter, 2016-07-29 23:58:46]

Description was changed from

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new URL.
This occurred if print preview was requested just after making
changes to an e-mail draft in a compose message window. Added test
that will not cause print preview to close in this case.

BUG= 614998
==========

to

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new URL. This occurred
if print preview was requested just after making changes to an e-mail draft in a
compose message window. Added test that will not cause print preview to close in
this case.

BUG= 614998
==========

[rbpotter, 2016-07-29 23:58:46]

rbpotter@chromium.org changed reviewers:
+ thestig@chromium.org

[rbpotter, 2016-07-30 00:03:49]

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_preview_dialog_controller.cc:324: if (nav_type ==
content::NAVIGATION_TYPE_EXISTING_PAGE &&
This condition covers the case that appears for the gmail update transition. I
have tested several other possible page transitions (e.g. navigating to a new
page, hitting refresh, navigating to a new tab via a link from print preview's
New Tab preview page, and manually making changes to the URL in gmail) that
should trigger a print preview close, and these all still work. Let me know if
you can think of a specific case that should trigger a print preview close that
might have a false positive here, and I will test.

[rbpotter, 2016-07-30 00:04:19]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 00:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-07-30 00:36:30]

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_preview_dialog_controller.cc:321: if (details) {
Isn't this handling navigation for both the initiator and the preview
WebContents? Should it only handle the initiator's navigation? In which case,
this probably should come after the "if (contents == preview_dialog)" block
below.

[commit-bot: I haz the power, 2016-07-30 00:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 00:57:25]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2016-07-30 01:06:44]

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_preview_dialog_controller.cc:321: if (details) {
On 2016/07/30 00:36:30, Lei Zhang wrote:
> Isn't this handling navigation for both the initiator and the preview
> WebContents? Should it only handle the initiator's navigation? In which case,
> this probably should come after the "if (contents == preview_dialog)" block
> below.

When the gmail auto-navigation happens, the contents == preview_dialog block
below never gets hit, which is why RemoveInitiator is called at the end of the
function. So contents != preview_dialog  for this case, which is why I put the
logic here. Not sure why this is the case though - any thoughts ?

[rbpotter, 2016-07-30 01:11:58]

The CQ bit was checked by rbpotter@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-30 01:12:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2016-07-30 01:20:18]

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
File chrome/browser/printing/print_preview_dialog_controller.cc (right):

https://codereview.chromium.org/2201543002/diff/1/chrome/browser/printing/pri...
chrome/browser/printing/print_preview_dialog_controller.cc:321: if (details) {
On 2016/07/30 00:36:30, Lei Zhang wrote:
> Isn't this handling navigation for both the initiator and the preview
> WebContents? Should it only handle the initiator's navigation? In which case,
> this probably should come after the "if (contents == preview_dialog)" block
> below.

Done.

[rbpotter, 2016-07-30 01:28:57]

Description was changed from

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new URL. This occurred
if print preview was requested just after making changes to an e-mail draft in a
compose message window. Added test that will not cause print preview to close in
this case.

BUG= 614998
==========

to

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new 
URL. This occurred if print preview was requested just after
making changes to an e-mail draft in a compose message 
window. Added test that will not cause print preview to close 
in this case.

BUG= 614998
==========

[Lei Zhang, 2016-07-30 01:30:50]

lgtm

[rbpotter, 2016-07-30 01:31:36]

Description was changed from

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new 
URL. This occurred if print preview was requested just after
making changes to an e-mail draft in a compose message 
window. Added test that will not cause print preview to close 
in this case.

BUG= 614998
==========

to

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998
==========

[commit-bot: I haz the power, 2016-07-30 02:44:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-30 02:44:05]

Dry run: This issue passed the CQ dry run.

[rbpotter, 2016-07-30 04:18:51]

The CQ bit was checked by rbpotter@chromium.org

[commit-bot: I haz the power, 2016-07-30 04:19:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-30 04:22:28]

Description was changed from

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998
==========

to

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998
==========

[commit-bot: I haz the power, 2016-07-30 04:22:29]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-30 04:24:07]

Description was changed from

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998
==========

to

==========
Fix print preview close in gmail.

Print preview closed in gmail when gmail navigated to a new
URL fragment. This occurred if print preview was requested
just after making changes to an e-mail draft in a compose
message window. Added check that will ensure print preview
remains open in this case.

BUG= 614998

Committed: https://crrev.com/85092cd8d7f4576aabaf2b9de9064978319c7388
Cr-Commit-Position: refs/heads/master@{#408860}
==========

[commit-bot: I haz the power, 2016-07-30 04:24:08]

Patchset 2 (id:??) landed as
https://crrev.com/85092cd8d7f4576aabaf2b9de9064978319c7388
Cr-Commit-Position: refs/heads/master@{#408860}